-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fleet] added CPU metrics to request diagnostics #179819
Conversation
/ci |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
@michel-laterman is this the right action format to request cpu metrics? When I tested, I didn't see any additional files in the diagnostics, should there be a
|
Looks correct, my e2e test is described in: elastic/fleet-server#3333 (comment) |
Thanks, I realized it only works with an agent 8.14, not earlier. Tested with a 8.14 agent: ![]() |
/ci |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code + UI LGTM 🚀
Pinging @elastic/fleet (Team:Fleet) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for the UI text! 👍
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
Summary
Closes #162849
Added option to request agent diagnostics with CPU metrics. This is a new checkbox in Request diagnostics modal. When clicked, the action will contain a
additional_metrics: ["CPU"]
.Also replaced the click handler of
Request diagnotics .zip
button in Agent Details / Diagnostics tab, to open the same modal instead of immediately triggering the action.To verify:
8.14-SNAPSHOT
cpu.pprof
fileAction created in
.fleet-actions
:Checklist
Delete any items that are not applicable to this PR.